Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: new failed repo sync test #13203

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

pnovotny
Copy link
Contributor

Notifications: new test for failed repo sync

This patch adds new API test for mail notification for a failed repository sync.

Other changes:

  • Waiting for desired e-mail has been refactored to wait_for_mail function so it is more reusable for other and future tests.
    Also wait_for:fail_condition lambda was fixed due to confusion about how it actually works.

  • Fixed one assert in test_positive_notification_for_long_running_tasks test.

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 29, 2023
@pnovotny pnovotny self-assigned this Nov 29, 2023
@pnovotny pnovotny requested review from pondrejk, lhellebr and a team November 29, 2023 05:35
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_positive_notification_failed_repo_sync

@pnovotny pnovotny marked this pull request as ready for review November 29, 2023 13:17
@pnovotny pnovotny requested a review from a team as a code owner November 29, 2023 13:17
This patch adds new API test for mail notification
for a failed repository sync.

Other changes:

- Waiting for desired e-mail has been refactored to `wait_for_mail` function
  be more reusable for other and future tests.
  Also `wait_for:fail_condition` lambda was fixed due to confusion
  how it actually works.

- Fixed one assert in `test_positive_notification_for_long_running_tasks` test.
@pnovotny pnovotny force-pushed the notifications-repo-sync branch from 662de6a to 4850d82 Compare November 29, 2023 16:36
@pnovotny
Copy link
Contributor Author

4850d82 - just a docs fix, no changes to the code itself.

@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_notifications.py -k test_positive_notification_failed_repo_sync

@ogajduse ogajduse merged commit 4d6b724 into SatelliteQE:master Dec 5, 2023
5 checks passed
@pnovotny pnovotny deleted the notifications-repo-sync branch December 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants